Skip to content

Conversation

@andtsa
Copy link
Member

@andtsa andtsa commented Aug 26, 2024

Version 1.2.0: Sponge Gourd

tl;dr:

  • gourd analyse redone, now supports:
    • CSV
    • custom columns
    • custom metrics
    • grouping
  • gourd.toml changes:
  • gourd set limits completely removed

breaking changes:

  • gourd analyse behaves very differently, check updated CLI documentation
  • gourd set limits does not exist at all, functionality is integrated in gourd rerun. or just update gourd.toml and run again normally
  • ...

maintainer changes:

  • can now create new metrics using ColumnGenerator(s)
  • new integration test framework
  • new pipeline with smaller actions for smaller PRs

qol changes:

  • pipeline artefacts expire every week

still todo:

  • fix divide by zero error in default metrics accumulator

  • write new gourd analyse user-end documentation

  • write col gen maintainer docs

  • write config() integration test maintainer docs

  • create issues for additional integration test scenarios desired (multi-step pipelines, more extensive gourd analyse testing, etc)

  • update version in code & docs

  • merge new afterscript documentation

  • write new postprocessing documentation (using next) & tutorial

  • documentation for slurm.{mail_type, begin, mail_user, additional_args}

  • for every value in constants.rs, mention the lines in documentation that need to be updated when the constant changes.

  • merge Simplified afterscripts #41

  • improve help for SLURM versioning failed error in cli

  • remove mentions of set_limits in documentation

  • ...

  • after everything else is done, update docs/maintainer/version-history/section.tex

@andtsa andtsa self-assigned this Aug 26, 2024
@andtsa

This comment was marked as outdated.

@andtsa
Copy link
Member Author

andtsa commented Aug 26, 2024

image

@andtsa andtsa force-pushed the grouping_2 branch 2 times, most recently from f8f8d34 to 0031d01 Compare September 24, 2024 16:40
Copy link
Contributor

@lchladek lchladek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good code, a few questions and some pre-flight reminders

@lchladek

This comment was marked as resolved.

@andtsa

This comment was marked as outdated.

@lchladek
Copy link
Contributor

Usability review part 2:

  • change '--save' to '-o/--out'
  • don't use humantime for timings, it's not readable, just make it seconds
  • is it possible to sum to an integer for things like swap count?
Screenshot 2024-09-24 at 13 59 33

@lchladek

This comment was marked as outdated.

@andtsa

This comment was marked as outdated.

lchladek

This comment was marked as outdated.

@lchladek

This comment was marked as outdated.

@lchladek

This comment was marked as resolved.

@lchladek

This comment was marked as resolved.

@andtsa

This comment was marked as resolved.

@andtsa

This comment was marked as outdated.

@lchladek

This comment was marked as outdated.

@lchladek

This comment was marked as resolved.

@andtsa

This comment was marked as resolved.

@andtsa

This comment was marked as outdated.

@lchladek

This comment was marked as outdated.

@andtsa

This comment was marked as resolved.

@lchladek

This comment was marked as resolved.

@andtsa

This comment was marked as resolved.

@andtsa andtsa added the ready run PR release pipeline (including documentation) label Oct 26, 2024
@andtsa andtsa requested a review from lchladek May 7, 2025 22:43
@andtsa andtsa added the release run release pipeline (generate installers) label May 7, 2025
@andtsa andtsa merged commit 694232c into main May 8, 2025
9 checks passed
@andtsa andtsa deleted the grouping_2 branch May 8, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready run PR release pipeline (including documentation) release run release pipeline (generate installers)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rewrite gourd.1 postprocessing Struggles with afterscripts Postprocess documentation

4 participants